Index | Thread | Search

From:
Kirill A. Korinsky <kirill@korins.ky>
Subject:
sys/xhci: avoid clear to zero maxBurst for Enhanced SuperSpeed
To:
OpenBSD tech <tech@openbsd.org>
Date:
Fri, 06 Nov 2026 11:54:32 +0100

Download raw body.

Thread
tech@,

I'm reading xhci and nearby to understand why ure is capped to ~1.5 Gbit and
so far I think I had spolied one missed case in xhci.

Section 6.2.3.4 of eXtensible Host Controller Interface for Universal Serial
Bus states that for for Enhanced SuperSpeed endpoints maxBurts for all
endpoints should be setup into bMaxBurst. At least I read it this way. See
page 455 here:
https://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/extensible-host-controler-interface-usb-xhci.pdf

Am I wrong?

Index: sys/dev/usb/xhci.c
===================================================================
RCS file: /home/cvs/src/sys/dev/usb/xhci.c,v
diff -u -p -r1.136 xhci.c
--- sys/dev/usb/xhci.c	1 Mar 2025 14:43:03 -0000	1.136
+++ sys/dev/usb/xhci.c	6 Nov 2026 10:26:02 -0000
@@ -1456,7 +1456,8 @@ xhci_pipe_maxburst(struct usbd_pipe *pip
 		break;
 	case USB_SPEED_SUPER:
 		if (esscd &&
-		    (xfertype == UE_ISOCHRONOUS || xfertype == UE_INTERRUPT))
+		    (xfertype == UE_ISOCHRONOUS || xfertype == UE_INTERRUPT ||
+		    xfertype == UE_BULK))
 			maxb = esscd->bMaxBurst;
 	default:
 		break;


-- 
wbr, Kirill