Index | Thread | Search

From:
Rafael Sadowski <rafael@sizeofvoid.org>
Subject:
Re: relayd: add "pass log" and "block log" to log filter decisions per request
To:
Theo de Raadt <deraadt@openbsd.org>
Cc:
tech@openbsd.org
Date:
Sun, 8 Nov 2026 10:58:07 +0100

Download raw body.

Thread
On Sun Nov 08, 2026 at 02:59:35AM -0600, Theo de Raadt wrote:
> > An unexpectedly simple diff to log all pass/block filter rules. The
> > syntax is the same as in pf.conf.
> 
> I don't think it is close enough to be called "same".
> 
> In pf.conf, the ordering of ruleset parameters is highly flexible.  The
> pfctl yacc grammer allows a majority of the parameters to be in any order,
> and then merges them in the end.
> 
> It looks like your grammer uses simpler methods which means their order
> is fixed.

Yes, that was worded a bit too quickly. It was more about the fact that
we can log an entire pass/block rule like pf.

The "log" keyword already exists, after all you do something like:

block request url log "open23.de/"
              ^^^^^^^
and if "log connection" is set you

relay https, session 1 (1 active), 0, 217.199.74.xx -> :0, Forbidden, ... Firefox/159.0] [/de/] [open23.de/de/] GET
                                                                                                 ^^^^^^^^^
instead of this (only "log connection"):
relay https, session 1 (1 active), 0, 217.199.74.xx -> :0, Forbidden, ... Firefox/159.0] [/de/] GET

That was never my design idea, I think a block/pass log is what you'd
want in the first place.

> 
> Not super important.  Having them in any order is not easy.  Maybe if
> the documentation compare this to pf.conf, then don't say it is "same",
> but at most "somewhat similar".  If it does not mention pf.conf, then
> that is easier..
> 

Will not mention it.