Index | Thread | Search

From:
hshoexer <hshoexer@yerbouti.franken.de>
Subject:
Re: SEV-SNP: bus_dma(9): Rescind and claim DMA bounce buffer
To:
tech@openbsd.org
Date:
Mon, 9 Nov 2026 11:37:38 +0100

Download raw body.

Thread
Hi,

On Fri, Nov 06, 2026 at 10:41:18AM +0100, hshoexer wrote:
> ...
> I will re-work the diffs then it's easier to reason about it :-)

I re-worked the diff to explicitly check for SNP.

ok?

Take care,
HJ.

-------------------------------------------------------------------
From 55687cc46e5097892728a7fae8f80a27cd975fbc Mon Sep 17 00:00:00 2001
From: hshoexer <hshoexer@yerbouti.franken.de>
Date: Fri, 25 Sep 2026 11:18:48 +0200
Subject: [PATCH 4/5] SEV-SNP: bus_dma(9): Grant and revoke DMA bounce buffer
 pages 4/5

When creating DMA maps, grant DMA bounce buffer pages to the
hypervisor.  When destroying DMA maps, revoke these pages from the
hypervisor.
---
 sys/arch/amd64/amd64/bus_dma.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/sys/arch/amd64/amd64/bus_dma.c b/sys/arch/amd64/amd64/bus_dma.c
index f4efff95a18..89a18ef9734 100644
--- a/sys/arch/amd64/amd64/bus_dma.c
+++ b/sys/arch/amd64/amd64/bus_dma.c
@@ -100,6 +100,7 @@
 #endif
 
 #include <machine/bus.h>
+#include <machine/snp.h>
 
 #include <uvm/uvm_extern.h>
 
@@ -184,6 +185,9 @@ _bus_dmamap_create(bus_dma_tag_t t, bus_size_t size, int nsegments,
 	/* allocate and use bounce buffers when running as SEV guest */
 	int use_bounce_buffer = cpu_sev_guestmode || FORCE_BOUNCE_BUFFER;
 	struct uvm_constraint_range *constraint = &no_constraint;
+#ifdef AMDSEV
+	int snp = ISSET(cpu_sev_guestmode, SEV_STAT_SNP_ACTIVE);
+#endif
 
 	if ((flags & BUS_DMA_64BIT) == 0 && bus_dma_high_pages > 0) {
 		use_bounce_buffer = 1;
@@ -255,6 +259,11 @@ _bus_dmamap_create(bus_dma_tag_t t, bus_size_t size, int nsegments,
 		return (ENOMEM);
 	}
 
+#ifdef AMDSEV
+	if (snp)
+		snp_grant_pages(&mlist);
+#endif
+
 	sva = va;
 	ssize = sz;
 	pgnext = TAILQ_FIRST(&mlist);
@@ -269,6 +278,10 @@ _bus_dmamap_create(bus_dma_tag_t t, bus_size_t size, int nsegments,
 			map->_dm_npages = 0;
 			km_free((void *)sva, ssize, &kv_any, &kp_none);
 			free(map, M_DEVBUF, mapsize);
+#ifdef AMDSEV
+			if (snp)
+				snp_revoke_pages(&mlist);
+#endif
 			uvm_pglistfree(&mlist);
 			return (ENOMEM);
 		}
@@ -292,6 +305,9 @@ _bus_dmamap_destroy(bus_dma_tag_t t, bus_dmamap_t map)
 	size_t mapsize;
 	struct vm_page **pg;
 	struct pglist mlist;
+#ifdef AMDSEV
+	int snp = ISSET(cpu_sev_guestmode, SEV_STAT_SNP_ACTIVE);
+#endif
 
 	if (map->_dm_pgva) {
 		km_free((void *)map->_dm_pgva, map->_dm_npages << PGSHIFT,
@@ -307,6 +323,10 @@ _bus_dmamap_destroy(bus_dma_tag_t t, bus_dmamap_t map)
 		for (pg = map->_dm_pages; map->_dm_npages--; pg++) {
 			TAILQ_INSERT_TAIL(&mlist, *pg, pageq);
 		}
+#ifdef AMDSEV
+		if (snp)
+			snp_revoke_pages(&mlist);
+#endif
 		uvm_pglistfree(&mlist);
 	}
 
-- 
2.56.0