Index | Thread | Search

From:
"Jan Fooken" <dev@janvhs.com>
Subject:
Re: patch: show an error when dired-do-copy fails due to permission issues
To:
"Jan Fooken" <dev@janvhs.com>, <tech@openbsd.org>
Date:
Thu, 12 Nov 2026 13:14:05 +0000

Download raw body.

Thread
Hi again,

A quick follow up, because I made a mistake in my last email.

> I took inspiration from the other error messages present in dired.c, but
> I would prefer to include the file name in the error.  What do you
> prefer?  I'll update my patch accordingly.

I meant fileio.c here.

> Furthermore, copy() always returns an integer greater than 0, so the
> error handling in d_copy() was dead code.

I meant greter or equal to 0.  Ironically making the same mistake in
writing that I intend on fixing in code.  The patch is still correct.


Sorry and kind regards,

Jan Fooken