Index | Thread | Search

From:
Ted Bullock <tbullock@comlore.com>
Subject:
Re: Testing Radeon console fixes on sparc64
To:
David Stanaway <david@stanaway.net>
Cc:
tech@openbsd.org
Date:
Thu, 12 Nov 2026 08:37:16 -0600

Download raw body.

Thread
  • Ted Bullock:

    Testing Radeon console fixes on sparc64

Hi David,

On Thu, 12 Nov 2026 at 05:31:25 +0000, David Stanaway wrote:
> This behavior for the console is much more usable, but not perfect.
>
> See attached. The font is inverted and a little unclear but actually
> useable to do some basic work on the console. Eg starting xenodm was easy.
>
> I manually applied the patch to 8.0 sys tree. So it looks like you removed
> some some set color calls and set color map , and just added  a BSWAP
> flag?

This looks like the 32 bit rasops blurred font problem Crystal and I worked
through on tech@ in October.

https://marc.info/?l=openbsd-tech&m=179175451732249&w=2

The renderer writes two pixels together as a 64 bit value. The byte
swapping on SPARC can reverse those pairs, which breaks up the lettering.
The patch below fixes that ordering and includes Crystal's changes.

I've put your photo here so the list can see what we're discussing:

https://downloads.comlore.com/openbsd/testing/radeon-console/20261112/console.jpg

The specific change here is to fix the blurred text with BSWAP on big endian, the black
background needs a different change to the driver itself but that should be
committed at the same time as this.

Thanks,
Ted

--- a/sys/dev/rasops/rasops32.c
+++ b/sys/dev/rasops/rasops32.c
@@ -62,18 +62,15 @@
  * Paint a single character.
  */
 int
 rasops32_putchar(void *cookie, int row, int col, u_int uc, uint32_t attr)
 {
-	int width, height, step, cnt, fs, b, f;
-	uint32_t fb, clr[2];
+	int width, height, step, cnt, fs, first_high;
+	uint32_t fb, clr[2], b, f;
 	struct rasops_info *ri;
-	int64_t *rp;
-	union {
-		int64_t q[4];
-		int32_t d[4][2];
-	} u;
+	uint64_t *rp;
+	uint64_t q[4];
 	u_char *fr;
 
 	ri = (struct rasops_info *)cookie;
 
 #ifdef RASOPS_CLIPPING
@@ -83,28 +80,41 @@
 
 	if ((unsigned)col >= (unsigned)ri->ri_cols)
 		return 0;
 #endif
 
-	rp = (int64_t *)(ri->ri_bits + row*ri->ri_yscale + col*ri->ri_xscale);
+	rp = (uint64_t *)(ri->ri_bits + row*ri->ri_yscale + col*ri->ri_xscale);
 
 	height = ri->ri_font->fontheight;
 	width = ri->ri_font->fontwidth;
 	step = ri->ri_stride >> 3;
 
 	b = ri->ri_devcmap[(attr >> 16) & 0xf];
 	f = ri->ri_devcmap[(attr >> 24) & 0xf];
-	u.d[0][0] = b; u.d[0][1] = b;
-	u.d[1][0] = b; u.d[1][1] = f;
-	u.d[2][0] = f; u.d[2][1] = b;
-	u.d[3][0] = f; u.d[3][1] = f;
+	/* Each table entry contains the colours for two adjacent pixels. */
+	q[0] = (uint64_t)b << 32 | b;
+	q[3] = (uint64_t)f << 32 | f;
+
+	/* A byte swapped framebuffer reverses the two pixels together. */
+	first_high = BYTE_ORDER == BIG_ENDIAN;
+#if NRASOPS_BSWAP > 0
+	if (ri->ri_flg & RI_BSWAP)
+		first_high = !first_high;
+#endif
+	if (first_high) {
+		q[1] = (uint64_t)b << 32 | f;
+		q[2] = (uint64_t)f << 32 | b;
+	} else {
+		q[1] = (uint64_t)f << 32 | b;
+		q[2] = (uint64_t)b << 32 | f;
+	}
 
 	if (uc == ' ') {
 		while (height--) {
 			/* the general, pixel-at-a-time case is fast enough */
 			for (cnt = 0; cnt < width; cnt++)
-				((int *)rp)[cnt] = b;
+				((uint32_t *)rp)[cnt] = b;
 			rp += step;
 		}
 	} else {
 		uc -= ri->ri_font->firstchar;
 		fr = (u_char *)ri->ri_font->data + uc * ri->ri_fontscale;
@@ -113,84 +123,84 @@
 		/* double-pixel special cases for the common widths */
 		switch (width) {
 		case 6:
 			while (height--) {
 				fb = fr[0];
-				rp[0] = u.q[fb >> 6];
-				rp[1] = u.q[(fb >> 4) & 3];
-				rp[2] = u.q[(fb >> 2) & 3];
+				rp[0] = q[fb >> 6];
+				rp[1] = q[(fb >> 4) & 3];
+				rp[2] = q[(fb >> 2) & 3];
 				rp += step;
 				fr += 1;
 			}
 			break;
 
 		case 8:
 			while (height--) {
 				fb = fr[0];
-				rp[0] = u.q[fb >> 6];
-				rp[1] = u.q[(fb >> 4) & 3];
-				rp[2] = u.q[(fb >> 2) & 3];
-				rp[3] = u.q[fb & 3];
+				rp[0] = q[fb >> 6];
+				rp[1] = q[(fb >> 4) & 3];
+				rp[2] = q[(fb >> 2) & 3];
+				rp[3] = q[fb & 3];
 				rp += step;
 				fr += 1;
 			}
 			break;
 
 		case 12:
 			while (height--) {
 				fb = fr[0];
-				rp[0] = u.q[fb >> 6];
-				rp[1] = u.q[(fb >> 4) & 3];
-				rp[2] = u.q[(fb >> 2) & 3];
-				rp[3] = u.q[fb & 3];
+				rp[0] = q[fb >> 6];
+				rp[1] = q[(fb >> 4) & 3];
+				rp[2] = q[(fb >> 2) & 3];
+				rp[3] = q[fb & 3];
 				fb = fr[1];
-				rp[4] = u.q[fb >> 6];
-				rp[5] = u.q[(fb >> 4) & 3];
+				rp[4] = q[fb >> 6];
+				rp[5] = q[(fb >> 4) & 3];
 				rp += step;
 				fr += 2;
 			}
 			break;
 
 		case 16:
 			while (height--) {
 				fb = fr[0];
-				rp[0] = u.q[fb >> 6];
-				rp[1] = u.q[(fb >> 4) & 3];
-				rp[2] = u.q[(fb >> 2) & 3];
-				rp[3] = u.q[fb & 3];
+				rp[0] = q[fb >> 6];
+				rp[1] = q[(fb >> 4) & 3];
+				rp[2] = q[(fb >> 2) & 3];
+				rp[3] = q[fb & 3];
 				fb = fr[1];
-				rp[4] = u.q[fb >> 6];
-				rp[5] = u.q[(fb >> 4) & 3];
-				rp[6] = u.q[(fb >> 2) & 3];
-				rp[7] = u.q[fb & 3];
+				rp[4] = q[fb >> 6];
+				rp[5] = q[(fb >> 4) & 3];
+				rp[6] = q[(fb >> 2) & 3];
+				rp[7] = q[fb & 3];
 				rp += step;
 				fr += 2;
 			}
 			break;
 
 		case 32:
 			while (height--) {
 				fb = fr[0];
-				rp[0] = u.q[fb >> 6];
-				rp[1] = u.q[(fb >> 4) & 3];
-				rp[2] = u.q[(fb >> 2) & 3];
-				rp[3] = u.q[fb & 3];
+				rp[0] = q[fb >> 6];
+				rp[1] = q[(fb >> 4) & 3];
+				rp[2] = q[(fb >> 2) & 3];
+				rp[3] = q[fb & 3];
 				fb = fr[1];
-				rp[4] = u.q[fb >> 6];
-				rp[5] = u.q[(fb >> 4) & 3];
-				rp[6] = u.q[(fb >> 2) & 3];
-				rp[7] = u.q[fb & 3];
+				rp[4] = q[fb >> 6];
+				rp[5] = q[(fb >> 4) & 3];
+				rp[6] = q[(fb >> 2) & 3];
+				rp[7] = q[fb & 3];
 				fb = fr[2];
-				rp[8] = u.q[fb >> 6];
-				rp[9] = u.q[(fb >> 4) & 3];
-				rp[10] = u.q[(fb >> 2) & 3];
-				rp[11] = u.q[fb & 3];
+				rp[8] = q[fb >> 6];
+				rp[9] = q[(fb >> 4) & 3];
+				rp[10] = q[(fb >> 2) & 3];
+				rp[11] = q[fb & 3];
 				fb = fr[3];
-				rp[12] = u.q[fb >> 6];
-				rp[13] = u.q[(fb >> 4) & 3];
-				rp[14] = u.q[(fb >> 2) & 3];
-				rp[15] = u.q[fb & 3];
+				rp[12] = q[fb >> 6];
+				rp[13] = q[(fb >> 4) & 3];
+				rp[14] = q[(fb >> 2) & 3];
+				rp[15] = q[fb & 3];
 				rp += step;
 				fr += 4;
 			}
 			break;
 
@@ -202,11 +212,11 @@
 				fb = fr[3] | (fr[2] << 8) | (fr[1] << 16) |
 				    (fr[0] << 24);
 				fr += fs;
 
 				for (cnt = 0; cnt < width; cnt++) {
-					((int *)rp)[cnt] = clr[fb >> 31];
+					((uint32_t *)rp)[cnt] = clr[fb >> 31];
 					fb <<= 1;
 				}
 				rp += step;
 			}
 			break;
@@ -215,10 +225,10 @@
 
 	/* Do underline a pixel at a time */
 	if ((attr & WSATTR_UNDERLINE) != 0) {
 		rp -= step;
 		for (cnt = 0; cnt < width; cnt++)
-			((int *)rp)[cnt] = f;
+			((uint32_t *)rp)[cnt] = f;
 	}
 
 	return 0;
 }