Index | Thread | Search

From:
Kenny <kenny.mlist@gmail.com>
Subject:
Fix -Wsingle-bit-bitfield-constant-conversion in net/fq_codel.c
To:
tech@openbsd.org
Date:
Fri, 13 Nov 2026 17:49:00 -0500

Download raw body.

Thread
  • Kenny:

    Fix -Wsingle-bit-bitfield-constant-conversion in net/fq_codel.c

Fix for warning

/sys/net/fq_codel.c:558:16: warning: implicit truncation from 'int'
to a one-bit wide bit-field changes value from 1 to -1
[-Wsingle-bit-bitfield-constant-conversion]

caused by flow->active = 1;


Index: net/fq_codel.c
===================================================================
RCS file: /cvs/src/sys/net/fq_codel.c,v
retrieving revision 1.22
diff -u -p -u -r1.22 fq_codel.c
--- net/fq_codel.c	25 Oct 2026 14:17:33 -0000	1.22
+++ net/fq_codel.c	13 Nov 2026 20:01:19 -0000
@@ -86,7 +86,7 @@ void		 codel_purge(struct codel *, struc
 
 struct flow {
 	struct codel		 cd;
-	int			 active:1;
+	unsigned int		 active:1;
 	int			 deficit:31;
 #ifdef FQCODEL_DEBUG
 	uint16_t		 id;