From: Marcus Glocker <marcus@nazgul.ch>
Subject: Re: sys/uvideo: dump bDescriptorSubtype for unsupported CS_INTERFACE when debug is enabled
To: "Kirill A. Korinsky" <kirill@korins.ky>
Cc: tech@openbsd.org
Date: Mon, 24 Feb 2025 12:50:05 +0100

On Sun, Feb 23, 2025 at 11:20:52AM GMT, Kirill A. Korinsky wrote:

> tech@,
> 
> I'd like to improve a bit uvideo_dump_desc_vc_header by dumping all
> bDescriptorSubtype for unsupported CS_INTERFACE.
> 
> Ok?

ok mglocker@
 
> Index: sys/dev/usb/uvideo.c
> ===================================================================
> RCS file: /home/cvs/src/sys/dev/usb/uvideo.c,v
> diff -u -p -r1.239 uvideo.c
> --- sys/dev/usb/uvideo.c	23 Feb 2025 08:28:57 -0000	1.239
> +++ sys/dev/usb/uvideo.c	23 Feb 2025 10:16:04 -0000
> @@ -2557,6 +2557,12 @@ uvideo_dump_desc_all(struct uvideo_softc
>  				printf("|\n");
>  				uvideo_dump_desc_colorformat(sc, desc);
>  				break;
> +			default:
> +				printf("bDescriptorSubtype=0x%02x",
> +				    desc->bDescriptorSubtype);
> +				printf(" (unknown)\n");
> +				break;
> +
>  			}
> 
>  			break;
>