From: Theo Buehler <tb@theobuehler.org>
Subject: Re: Fault upgrade counters
To: tech@openbsd.org
Date: Mon, 24 Feb 2025 13:02:06 +0100

On Mon, Feb 24, 2025 at 12:36:34PM +0100, Martin Pieuchot wrote:
> Diff below adds a new counter to measure lock upgrades, documents it and
> unifies the re-lock counters to do only one atomic operation instead of
> two.
> 
> ok?

Is there a reason that you didn't add flt_{,no}up to vmstat.c?

other than that this reads ok

> Index: usr.bin/systat/vmstat.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/systat/vmstat.c,v
> diff -u -p -r1.96 vmstat.c
> --- usr.bin/systat/vmstat.c	28 Dec 2022 20:49:05 -0000	1.96
> +++ usr.bin/systat/vmstat.c	24 Feb 2025 11:22:08 -0000
> @@ -407,7 +407,7 @@ showkre(void)
>  	PUTRATE(uvmexp.forks_sharevm, VMSTATROW + 2, VMSTATCOL + 3, 6);
>  	PUTRATE(uvmexp.fltpgwait, VMSTATROW + 3, VMSTATCOL + 4, 5);
>  	PUTRATE(uvmexp.fltrelck, VMSTATROW + 4, VMSTATCOL + 3, 6);
> -	PUTRATE(uvmexp.fltrelckok, VMSTATROW + 5, VMSTATCOL + 3, 6);
> +	PUTRATE(uvmexp.fltnorelck, VMSTATROW + 5, VMSTATCOL + 3, 6);
>  	PUTRATE(uvmexp.fltnoram, VMSTATROW + 6, VMSTATCOL + 3, 6);
>  	PUTRATE(uvmexp.fltamcopy, VMSTATROW + 7, VMSTATCOL + 3, 6);
>  	PUTRATE(uvmexp.flt_prcopy, VMSTATROW + 8, VMSTATCOL + 3, 6);
> 
>