From: Alexandr Nedvedicky <sashan@fastmail.net>
Subject: Re: merge divert6 into divert
To: Alexander Bluhm <alexander.bluhm@gmx.net>
Cc: tech@openbsd.org
Date: Mon, 1 Jan 2024 19:08:36 +0100

On Mon, Jan 01, 2024 at 06:10:17PM +0100, Alexander Bluhm wrote:
> Hi,
> 
> There is a lot of code duplication in netinet6/ip6_divert.c.  Other
> protocols like UDP or TCP only keep functions that are essentially
> different.  This also makes code review and understanding easier.
> 
> In a fist sweep remove divert6_detach, divert6_lock, divert6_unlock,
> divert6_bind, and divert6_shutdown.  The IPv4 code is identical.
> 
> Note that INP_HDRINCL is an IPv4 only option.  It should not be in
> divert6_attach.
> 
> ok?

    Nice, I like it.

OK sashan