From: Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject: Re: bgpd rewrite rtr pdu parser to new ibuf API
To: Theo Buehler <tb@theobuehler.org>
Cc: tech@openbsd.org
Date: Thu, 4 Jan 2024 14:15:38 +0100

On Thu, Jan 04, 2024 at 12:57:36PM +0100, Theo Buehler wrote:
> On Thu, Jan 04, 2024 at 11:36:40AM +0100, Claudio Jeker wrote:
> > This diff converts the RTR PDU parser to use the ibuf API.
> > More cleanup is possible but lets start with a "minimal" conversion.
> 
> Yes, it's big enough.
> 
> > The ASPA PDU handling is maybe a bit ugly but that part will change once
> > SIDROPS made up their mind about how this PDU should look like.
> 
> :)
> 
> > This introduces ibuf_get_string() which I plan to add to libutil since I
> > used the same function in xlock privsep code. Extracting a string from
> > an imsg seems to be somewhat common and this API ensures that the string
> > is NUL terminated.
> 
> This generally looks good. I think there's one bug due to the removal of
> the rv dance in rtr_parse_error(). Apart from that it's just nits as
> usual.
> 

Updated version. The rv dance in rtr_parse_error() is an unrelated change
and I reverted it.

-- 
:wq Claudio