From: Stefan Sperling <stsp@stsp.name>
Subject: Re: explicitly disable Energy-Efficient Ethernet (EEE) on Marvell E151x
To: Uwe Stuehler <ustuehler@growit.io>
Cc: tech@openbsd.org
Date: Thu, 11 Jan 2024 14:06:29 +0100

On Thu, Jan 11, 2024 at 01:59:13PM +0100, Uwe Stuehler wrote:
> The Energy Detect feature which is part of EEE defaults to off on both
> hardware and software reset to enter "normal 10/100/1000 Mbps operation"
> but this change makes it explicit, as with other PHYs in that family.
> 
> Note that, if EEE was enabled, an errata would apply which requires a
> certain sequence of magic register writes. Linux and other systems have
> that errata implemented, but we don't need it yet.
> 
> ok?

ok stsp@

> diff --git a/sys/dev/mii/eephy.c b/sys/dev/mii/eephy.c
> index c99bac094dd..075c4836197 100644
> --- a/sys/dev/mii/eephy.c
> +++ b/sys/dev/mii/eephy.c
> @@ -273,6 +273,7 @@ eephy_reset(struct mii_softc *sc)
>  	case MII_MODEL_MARVELL_E1011:
>  	case MII_MODEL_MARVELL_E1111:
>  	case MII_MODEL_MARVELL_E1112:
> +	case MII_MODEL_MARVELL_E1512:
>  	case MII_MODEL_MARVELL_PHYG65G:
>  		reg &= ~E1000_SCR_EN_DETECT_MASK;
>  		break;
> 
>