From: Theo Buehler <tb@theobuehler.org>
Subject: Re: bgpd: first stab at converting session.c to new imsg API
To: tech@openbsd.org
Date: Fri, 12 Jan 2024 09:00:47 +0100

On Thu, Jan 11, 2024 at 04:20:13PM +0100, Claudio Jeker wrote:
> This diff transforms most of session.c to use the new imsg API. I skipped
> IMSG_UPDATE and IMSG_UPDATE_ERR for now since those bring you down into
> some deep deep rabbit holes. So that will follow later.

Thanks for cutting these into relatively easy-to-digest chunks.

ok tb

> @@ -3302,16 +3307,14 @@ session_dispatch_imsg(struct imsgbuf *im
>  		case IMSG_SESSION_RESTARTED:
>  			if (idx != PFD_PIPE_ROUTE)
>  				fatalx("update request not from RDE");

'udpate request' looks like a copy-paste error

> @@ -3333,9 +3336,8 @@ session_dispatch_imsg(struct imsgbuf *im
>  		case IMSG_SESSION_DOWN:
>  			if (idx != PFD_PIPE_ROUTE)
>  				fatalx("update request not from RDE");

same here.