From: Omar Polo <op@omarpolo.com>
Subject: Re: smtpd: convert to imsg_get_fd()
To: Claudio Jeker <cjeker@diehard.n-r-g.com>
Cc: tech@openbsd.org
Date: Fri, 19 Jan 2024 16:47:21 +0100

On 2024/01/18 16:48:42 +0100, Claudio Jeker <cjeker@diehard.n-r-g.com> wrote:
> smtpd is the last program in base that needs to be converted to use
> imsg_get_fd(). It is also a little bit the reason for this conversion
> since with imsg_get_fd() the owner of the fd is will known and imsg_free()
> will soon start to close unclaimed fds. This prevents unexpected fd leaks.
> 
> Now smtpd does a lot of fd passing but most of it is simple.
> In log_imsg() imsg.fd can no longer be inspected. I hope this is OK.
> This inspection in debug code violates the ownership principle.
> In my opinion logging the fd is not very helpful since fds are reused
> quickly.
> 
> Please test if you use smtpd in more than the base config.

The diffs reads fine to me, ok op@

I'm running this on my instance (which is not super complex but not the
base config either.)


Thanks,

Omar Polo