From: Krystian Lewandowski <k.lewandowski@icloud.com>
Subject: radiusd: LDADD, DPADD mixup?
To: tech@openbsd.org
Date: Sun, 28 Jan 2024 14:48:29 +0100

I found a problem while trying to cross compile for armv7 - the linker
was looking for libraries in /usr/lib.

I would assume the idea was to use DPADD and LDADD, not just LDADD.

There are other places where these variables are used the same way this
patch does:
https://cvsweb.openbsd.org/src/usr.sbin/radiusctl/Makefile

Regards,
-- 
Krystian Lewandowski

Index: usr.sbin/radiusd/radiusd_bsdauth/Makefile
===================================================================
RCS file: /cvs/src/usr.sbin/radiusd/radiusd_bsdauth/Makefile,v
retrieving revision 1.1
diff -u -p -r1.1 Makefile
--- usr.sbin/radiusd/radiusd_bsdauth/Makefile 21 Jul 2015 04:06:04 -0000 1.1
+++ usr.sbin/radiusd/radiusd_bsdauth/Makefile 28 Jan 2024 07:23:49 -0000
@@ -3,7 +3,7 @@ PROG= radiusd_bsdauth
 BINDIR= /usr/libexec/radiusd
 SRCS= radiusd_bsdauth.c radiusd_module.c imsg_subr.c
 LDADD+= -lradius -lcrypto -lutil
-LDADD+= ${LIBRADIUS} ${LIBCRYPTO} ${LIBUTIL}
+DPADD+= ${LIBRADIUS} ${LIBCRYPTO} ${LIBUTIL}
 NOMAN= #
   .include <bsd.prog.mk>
Index: usr.sbin/radiusd/radiusd_radius/Makefile
===================================================================
RCS file: /cvs/src/usr.sbin/radiusd/radiusd_radius/Makefile,v
retrieving revision 1.1
diff -u -p -r1.1 Makefile
--- usr.sbin/radiusd/radiusd_radius/Makefile 21 Jul 2015 04:06:04 -0000 1.1
+++ usr.sbin/radiusd/radiusd_radius/Makefile 28 Jan 2024 07:23:49 -0000
@@ -4,7 +4,7 @@ BINDIR= /usr/libexec/radiusd
 SRCS= radiusd_radius.c radiusd_module.c util.c imsg_subr.c log.c
 CFLAGS+= -DUSE_LIBEVENT
 LDADD+= -lradius -lcrypto -lutil -levent
-LDADD+= ${LIBRADIUS} ${LIBCRYPTO} ${LIBUTIL} ${LIBEVENT}
+DPADD+= ${LIBRADIUS} ${LIBCRYPTO} ${LIBUTIL} ${LIBEVENT}
 NOMAN= #
   .include <bsd.prog.mk>