From: Christian Weisgerber <naddy@mips.inka.de>
Subject: Re: rpki-client: change SHA256_{Init,Update,Final} to EVP_Digest{Init_ex,Update,Final_ex}
To: Job Snijders <job@openbsd.org>
Cc: tech@openbsd.org
Date: Wed, 28 Feb 2024 21:47:32 +0100

Job Snijders:

> Changing the following to help with future portability.

Regardless whether we want that...

> -					SHA256_Init(&s->ctx);
> +					s->ctx = EVP_MD_CTX_new();
> +					EVP_DigestInit_ex(s->ctx, EVP_sha256(),
> +					    NULL);

... don't you need to check/handle at least EVP_MD_CTX_new() failure?

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de