From: Job Snijders <job@openbsd.org>
Subject: Re: rpki-client: change SHA256_{Init,Update,Final} to EVP_Digest{Init_ex,Update,Final_ex}
To: Christian Weisgerber <naddy@mips.inka.de>
Cc: tech@openbsd.org
Date: Wed, 28 Feb 2024 20:53:13 +0000

On Wed, Feb 28, 2024 at 09:47:32PM +0100, Christian Weisgerber wrote:
> > -					SHA256_Init(&s->ctx);
> > +					s->ctx = EVP_MD_CTX_new();
> > +					EVP_DigestInit_ex(s->ctx, EVP_sha256(),
> > +					    NULL);
> 
> ... don't you need to check/handle at least EVP_MD_CTX_new() failure?

Yes, mea culpa, the changeset lacked error checking. 

Kind regards,

Job