From: Jonathan Gray <jsg@jsg.id.au>
Subject: Re: Alder Lake eMMC needs the same 0V quirk as Jasper/Apollo/Gemini Lake
To: Colin Didier <cdidier@cybione.org>
Cc: tech@openbsd.org
Date: Fri, 29 Mar 2024 10:39:19 +1100

On Thu, Mar 28, 2024 at 04:10:57PM +0100, Colin Didier wrote:
> fixes accessing eMMC on MeLE Quieter 4C.
> 
> before:
> sdhc0 at pci0 dev 26 function 0 "Intel ADL-N eMMC" rev 0x00: apic 2 int 16
> sdhc0: SDHC 3.00, 200 MHz base clock
> sdmmc0 at sdhc0: 8-bit, sd high-speed, mmc high-speed, ddr52, dma
> sdmmc0: can't enable card
> 
> after:
> sdhc0 at pci0 dev 26 function 0 "Intel ADL-N eMMC" rev 0x00: apic 2 int 16
> sdhc0: SDHC 3.00, 200 MHz base clock
> sdmmc0 at sdhc0: 8-bit, sd high-speed, mmc high-speed, ddr52, dma
> scsibus1 at sdmmc0: 2 targets, initiator 0
> sd0 at scsibus1 targ 1 lun 0: <SD/MMC, A3A562, 0000> removable
> sd0: 118000MB, 512 bytes/sector, 241664000 sectors

thanks, committed

> 
> Index: sys/dev/pci/sdhc_pci.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/sdhc_pci.c,v
> retrieving revision 1.24
> diff -u -p -u -p -r1.24 sdhc_pci.c
> --- sys/dev/pci/sdhc_pci.c	11 Mar 2022 18:00:51 -0000	1.24
> +++ sys/dev/pci/sdhc_pci.c	28 Mar 2024 01:54:59 -0000
> @@ -131,7 +131,8 @@ sdhc_pci_attach(struct device *parent, s
>  	   (PCI_PRODUCT(pa->pa_id) == PCI_PRODUCT_INTEL_100SERIES_LP_EMMC ||
>  	   PCI_PRODUCT(pa->pa_id) == PCI_PRODUCT_INTEL_APOLLOLAKE_EMMC ||
>  	   PCI_PRODUCT(pa->pa_id) == PCI_PRODUCT_INTEL_GLK_EMMC ||
> -	   PCI_PRODUCT(pa->pa_id) == PCI_PRODUCT_INTEL_JSL_EMMC))
> +	   PCI_PRODUCT(pa->pa_id) == PCI_PRODUCT_INTEL_JSL_EMMC ||
> +	   PCI_PRODUCT(pa->pa_id) == PCI_PRODUCT_INTEL_ADL_N_EMMC))
>  		sc->sc.sc_flags |= SDHC_F_NOPWR0;
>  
>  	/* Some RICOH controllers need to be bumped into the right mode. */
> 
>