From: Alexander Bluhm <bluhm@openbsd.org>
Subject: Re: Remove wrong "temporary udp error" comment in filt_so{read,write}()
To: Vitaliy Makkoveev <mvs@openbsd.org>
Cc: tech@openbsd.org
Date: Mon, 1 Apr 2024 23:25:23 +0200

On Mon, Apr 01, 2024 at 12:00:10AM +0300, Vitaliy Makkoveev wrote:
> Not only udp(4) sockets set and check `so_error'.

This comment was copied from FreeBSD in 2000.  I don't understand it.

OK bluhm@

> Index: sys/kern/uipc_socket.c
> ===================================================================
> RCS file: /cvs/src/sys/kern/uipc_socket.c,v
> retrieving revision 1.325
> diff -u -p -r1.325 uipc_socket.c
> --- sys/kern/uipc_socket.c	31 Mar 2024 14:01:28 -0000	1.325
> +++ sys/kern/uipc_socket.c	31 Mar 2024 20:58:15 -0000
> @@ -2290,7 +2290,7 @@ filt_soread(struct knote *kn, long hint)
>  		}
>  		kn->kn_fflags = so->so_error;
>  		rv = 1;
> -	} else if (so->so_error) {	/* temporary udp error */
> +	} else if (so->so_error) {
>  		rv = 1;
>  	} else if (kn->kn_sfflags & NOTE_LOWAT) {
>  		rv = (kn->kn_data >= kn->kn_sdata);
> @@ -2327,7 +2327,7 @@ filt_sowrite(struct knote *kn, long hint
>  		}
>  		kn->kn_fflags = so->so_error;
>  		rv = 1;
> -	} else if (so->so_error) {	/* temporary udp error */
> +	} else if (so->so_error) {
>  		rv = 1;
>  	} else if (((so->so_state & SS_ISCONNECTED) == 0) &&
>  	    (so->so_proto->pr_flags & PR_CONNREQUIRED)) {