From: Florian Obser <florian@openbsd.org>
Subject: Re: acme-client: garbage collect unused url in netproc()
To: Theo Buehler <tb@theobuehler.org>
Cc: tech@openbsd.org
Date: Sun, 28 Apr 2024 11:54:29 +0200

OK

On 2024-04-28 10:36 +02, Theo Buehler <tb@theobuehler.org> wrote:
> When RFC 8555 support was added in r1.23, token and url were left
> unused. token was removed a day later. url had to wait a bit longer.
>
> Index: netproc.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/acme-client/netproc.c,v
> diff -u -p -r1.34 netproc.c
> --- netproc.c	28 Apr 2024 08:29:56 -0000	1.34
> +++ netproc.c	28 Apr 2024 08:35:19 -0000
> @@ -663,7 +663,7 @@ netproc(int kfd, int afd, int Cfd, int c
>  {
>  	int		 rc = 0;
>  	size_t		 i;
> -	char		*cert = NULL, *thumb = NULL, *url = NULL, *error = NULL;
> +	char		*cert = NULL, *thumb = NULL, *error = NULL;
>  	struct conn	 c;
>  	struct capaths	 paths;
>  	struct order	 order;
> @@ -898,7 +898,6 @@ out:
>  	close(dfd);
>  	close(rfd);
>  	free(cert);
> -	free(url);
>  	free(thumb);
>  	free(c.kid);
>  	free(c.buf.buf);
>

-- 
In my defence, I have been left unsupervised.