From: Sebastien Marie <semarie@kapouay.eu.org>
Subject: patch: vfs: struct vops: show all members, even if NULL
To: tech@openbsd.org
Date: Tue, 07 May 2024 10:21:54 +0200

Hi,

In order to help code maintenance, I would like to explicitly add all
`struct vops` members with the current value (if not present, it is
NULL), still using C99 notation.

It helps me a lot to navigate in code with simple tools (like grep), and
ensure I will not miss a default case.

The missing fields are added following the `struct vops` order. I didn't
changed fields order to avoid ask myself what would be the better order
to use. It could be done later if desirable, and it will not obscurant
this diff.

No function code changes intented.

Comments or OK ?
-- 
Sebastien Marie


diff /home/semarie/repos/openbsd/src
commit - 21e142091427cef1ae08d0c57a9429980d4d2ba3
path + /home/semarie/repos/openbsd/src
blob - e55770118a09e95f05ac41b39575341d37010efc
file + sys/isofs/udf/udf_vnops.c
--- sys/isofs/udf/udf_vnops.c
+++ sys/isofs/udf/udf_vnops.c
@@ -75,7 +75,24 @@ const struct vops udf_vops = {
 	.vop_unlock	= udf_unlock,
 	.vop_pathconf	= udf_pathconf,
 	.vop_islocked	= udf_islocked,
-	.vop_print	= udf_print
+	.vop_print	= udf_print,
+
+	.vop_abortop	= NULL,
+	.vop_advlock	= NULL,
+	.vop_bwrite	= NULL,
+	.vop_create	= NULL,
+	.vop_fsync	= NULL,
+	.vop_link	= NULL,
+	.vop_mknod	= NULL,
+	.vop_remove	= NULL,
+	.vop_rename	= NULL,
+	.vop_revoke	= NULL,
+	.vop_mkdir	= NULL,
+	.vop_rmdir	= NULL,
+	.vop_setattr	= NULL,
+	.vop_symlink	= NULL,
+	.vop_write	= NULL,
+	.vop_kqfilter	= NULL,
 };
 
 #define UDF_INVALID_BMAP	-1
blob - 8108e6d5a5036d6353cc3a325ded809cd03b68df
file + sys/kern/vfs_sync.c
--- sys/kern/vfs_sync.c
+++ sys/kern/vfs_sync.c
@@ -220,7 +220,34 @@ const struct vops sync_vops = {
 	.vop_lock	= nullop,
 	.vop_unlock	= nullop,
 	.vop_islocked	= nullop,
-	.vop_print	= sync_print
+	.vop_print	= sync_print,
+
+	.vop_abortop	= NULL,
+	.vop_access	= NULL,
+	.vop_advlock	= NULL,
+	.vop_bmap	= NULL,
+	.vop_bwrite	= NULL,
+	.vop_create	= NULL,
+	.vop_getattr	= NULL,
+	.vop_ioctl	= NULL,
+	.vop_link	= NULL,
+	.vop_lookup	= NULL,
+	.vop_mknod	= NULL,
+	.vop_open	= NULL,
+	.vop_pathconf	= NULL,
+	.vop_read	= NULL,
+	.vop_readdir	= NULL,
+	.vop_readlink	= NULL,
+	.vop_remove	= NULL,
+	.vop_rename	= NULL,
+	.vop_revoke	= NULL,
+	.vop_mkdir	= NULL,
+	.vop_rmdir	= NULL,
+	.vop_setattr	= NULL,
+	.vop_strategy	= NULL,
+	.vop_symlink	= NULL,
+	.vop_write	= NULL,
+	.vop_kqfilter	= NULL,
 };
 
 /*
blob - 97b14c1bf2d1cdd5e41df48baf97de3a10c11389
file + sys/miscfs/fifofs/fifo_vnops.c
--- sys/miscfs/fifofs/fifo_vnops.c
+++ sys/miscfs/fifofs/fifo_vnops.c
@@ -97,7 +97,7 @@ const struct vops fifo_vops = {
 	.vop_print	= fifo_print,
 	.vop_pathconf	= fifo_pathconf,
 	.vop_advlock	= fifo_advlock,
-	.vop_bwrite	= nullop
+	.vop_bwrite	= nullop,
 };
 
 void	filt_fifordetach(struct knote *kn);
blob - 7bb05c1f6333d819ea2846bb5054ccd3bec30589
file + sys/nfs/nfs_vnops.c
--- sys/nfs/nfs_vnops.c
+++ sys/nfs/nfs_vnops.c
@@ -161,7 +161,7 @@ const struct vops nfs_vops = {
 	.vop_islocked	= nfs_islocked,
 	.vop_pathconf	= nfs_pathconf,
 	.vop_advlock	= nfs_advlock,
-	.vop_bwrite	= nfs_bwrite
+	.vop_bwrite	= nfs_bwrite,
 };
 
 /* Special device vnode ops. */
blob - d239112e991fe0f365d124a35ce52765fe959114
file + sys/ntfs/ntfs_vnops.c
--- sys/ntfs/ntfs_vnops.c
+++ sys/ntfs/ntfs_vnops.c
@@ -681,4 +681,21 @@ const struct vops ntfs_vops = {
 	.vop_strategy	= ntfs_strategy,
 	.vop_bwrite	= vop_generic_bwrite,
 	.vop_read	= ntfs_read,
+
+	.vop_abortop	= NULL,
+	.vop_advlock	= NULL,
+	.vop_create	= NULL,
+	.vop_ioctl	= NULL,
+	.vop_link	= NULL,
+	.vop_mknod	= NULL,
+	.vop_readlink	= NULL,
+	.vop_remove	= NULL,
+	.vop_rename	= NULL,
+	.vop_revoke	= NULL,
+	.vop_mkdir	= NULL,
+	.vop_rmdir	= NULL,
+	.vop_setattr	= NULL,
+	.vop_symlink	= NULL,
+	.vop_write	= NULL,
+	.vop_kqfilter	= NULL,
 };
blob - f7f359ccc0797fcfab993187b5026d701c7a66b2
file + sys/ufs/ffs/ffs_vnops.c
--- sys/ufs/ffs/ffs_vnops.c
+++ sys/ufs/ffs/ffs_vnops.c
@@ -91,7 +91,7 @@ const struct vops ffs_vops = {
 	.vop_islocked	= ufs_islocked,
 	.vop_pathconf	= ufs_pathconf,
 	.vop_advlock	= ufs_advlock,
-	.vop_bwrite	= vop_generic_bwrite
+	.vop_bwrite	= vop_generic_bwrite,
 };
 
 const struct vops ffs_specvops = {
@@ -170,7 +170,7 @@ const struct vops ffs_fifovops = {
 	.vop_bmap	= vop_generic_bmap,
 	.vop_strategy	= vop_generic_badop,
 	.vop_pathconf	= fifo_pathconf,
-	.vop_advlock	= fifo_advlock
+	.vop_advlock	= fifo_advlock,
 };
 #endif /* FIFO */
 
blob - f238af203263969d7b8765d01a7514578743ba6a
file + sys/ufs/mfs/mfs_vnops.c
--- sys/ufs/mfs/mfs_vnops.c
+++ sys/ufs/mfs/mfs_vnops.c
@@ -81,7 +81,7 @@ const struct vops mfs_vops = {
         .vop_print      = mfs_print,
         .vop_pathconf   = vop_generic_badop,
         .vop_advlock    = vop_generic_badop,
-        .vop_bwrite     = vop_generic_bwrite
+        .vop_bwrite     = vop_generic_bwrite,
 };
 
 /*