From: Jonathan Gray Subject: Re: unneeded #includes in sys/dev/ic To: David Rinehart Cc: tech@openbsd.org Date: Sun, 26 May 2024 09:53:09 +1000 On Sat, May 25, 2024 at 02:00:53PM -0700, David Rinehart wrote: > On Sat, 2024-05-25 at 18:29 +1000, Jonathan Gray wrote: > > +#define TRUE 1 > > +#define FALSE 0 > >   > > I'm not familiar with the detail of this code, but isn't TRUE typically > defined as !FALSE? no, and the usage here matches that in uvm bin/csh/file.c:#define TRUE 1 distrib/special/more/curses.h:#define TRUE (1) games/adventure/hdr.h:#define TRUE 1 games/hack/config.h:#define TRUE 1 games/monop/initdeck.c:#define TRUE 1 games/monop/monop.h:#define TRUE (1) games/quiz/quiz.h:#define TRUE 1 gnu/usr.bin/binutils-2.17/bfd/bfd-in.h:#define TRUE 1 gnu/usr.bin/binutils-2.17/bfd/bfd-in2.h:#define TRUE 1 gnu/usr.bin/binutils-2.17/gas/config/obj-elf.h:#define TRUE !FALSE gnu/usr.bin/binutils-2.17/gas/config/obj-som.h:#define TRUE !FALSE gnu/usr.bin/binutils-2.17/gas/config/tc-hppa.h:#define TRUE (!FALSE) gnu/usr.bin/binutils-2.17/gas/config/tc-pdp11.c:#define TRUE 1 gnu/usr.bin/binutils-2.17/gas/atof-generic.c:#define TRUE (1) gnu/usr.bin/binutils/bfd/bfd-in.h:#define TRUE 1 gnu/usr.bin/binutils/bfd/bfd-in2.h:#define TRUE 1 gnu/usr.bin/binutils/gas/config/obj-elf.h:#define TRUE !FALSE gnu/usr.bin/binutils/gas/config/obj-som.h:#define TRUE !FALSE gnu/usr.bin/binutils/gas/config/tc-hppa.h:#define TRUE (!FALSE) gnu/usr.bin/binutils/gas/config/tc-pdp11.c:#define TRUE 1 gnu/usr.bin/binutils/gas/atof-generic.c:#define TRUE (1) gnu/usr.bin/binutils/gdb/rdi-share/host.h:#define TRUE true gnu/usr.bin/binutils/gdb/testsuite/gdb.trace/gdb_c_test.c:#define TRUE 1 gnu/usr.bin/binutils/gdb/vx-share/vxWorks.h:#define TRUE 1 gnu/usr.bin/cvs/vms/misc.c:#define TRUE 1 gnu/usr.bin/gcc/gcc/testsuite/g++.old-deja/g++.mike/p1989.C:#define TRUE true gnu/usr.bin/gcc/gcc/testsuite/g++.old-deja/g++.mike/p658.C:#define TRUE true gnu/usr.bin/gcc/gcc/testsuite/gcc.c-torture/execute/tstdi-1.c:#define TRUE 13 gnu/usr.bin/gcc/gcc/testsuite/gcc.dg/cpp/skipping.c:#define TRUE 1 gnu/usr.bin/gcc/gcc/testsuite/gcc.misc-tests/sieve.c:#define TRUE 1 gnu/usr.bin/gcc/gcc/system.h:#define TRUE true gnu/usr.bin/perl/pod/perlfilter.pod: 2: #define TRUE 1 gnu/usr.bin/perl/pod/perlfilter.pod: 2: #define TRUE 1 gnu/usr.bin/perl/handy.h:#define TRUE (1) gnu/usr.sbin/mkhybrid/src/mkisofs.c:#define TRUE 1 lib/libc/time/private.h:#define TRUE 1 lib/libcurses/curses.h:#define TRUE 1 sys/arch/hppa/spmath/float.h:#define TRUE (!FALSE) sys/arch/hppa/spmath/md.h:#define TRUE (!FALSE) sys/dev/ic/aic79xx.h:#define TRUE 1 sys/dev/ic/aic7xxxvar.h:#define TRUE 1 sys/dev/ic/bt8xx.h:#define TRUE 1 sys/dev/microcode/aic7xxx/aicasm.h:#define TRUE 1 sys/dev/pci/if_em.h:#define TRUE 1 sys/dev/pci/if_ixgb.h:#define TRUE 1 sys/dev/pci/if_oce.c:#define TRUE 1 sys/dev/pci/ixgbe.h:#define TRUE 1 sys/dev/pci/ixgbe.h:#define TRUE 1 sys/stand/efi/include/efidef.h: #define TRUE ((BOOLEAN) 1) sys/uvm/uvm_param.h:#define TRUE 1 usr.bin/gprof/gprof.h:#define TRUE 1 usr.bin/less/less.h:#define TRUE 1 usr.bin/m4/mdef.h:#define TRUE 1 usr.bin/mg/def.h:#define TRUE 1 /* True, yes, good, etc. */ usr.bin/rdist/defs.h:#define TRUE 1 usr.bin/ssh/pkcs11.h:#define TRUE 1 usr.sbin/amd/include/am.h:#define TRUE 1 usr.sbin/apm/apm.c:#define TRUE 1 usr.sbin/cron/macros.h:#define TRUE 1 usr.sbin/mrouted/defs.h:#define TRUE 1 usr.sbin/pppd/auth.c:#define TRUE 1 usr.sbin/pppd/options.c:#define TRUE 1 usr.sbin/pppd/pppd.h:#define TRUE 1 usr.sbin/tcpdump/print-l2tp.c:#define TRUE 1 usr.sbin/wsmoused/wsmoused.h:#define TRUE 1 usr.sbin/zic/zic.c:#define TRUE 1 usr.sbin/ypserv/common/ypdef.h:#define TRUE 1 usr.sbin/ypserv/ypserv/acl.c:#define TRUE 1 usr.sbin/zdump/zdump.c:#define TRUE 1