From: Jonathan Gray <jsg@jsg.id.au>
Subject: Re: Minor fixes, style corrections, superfluous variables, and so on.
To: jon@elytron.openbsd.amsterdam
Cc: tech@openbsd.org
Date: Wed, 29 May 2024 17:03:41 +1000

On Wed, May 29, 2024 at 04:39:37AM +0000, jon@elytron.openbsd.amsterdam wrote:
> Hello, everyone. I just thought I should share very minor nitpicks
> I have found over time in the kernel code. Most of them I have 
> already posted in one way or another. They are
> 
> 1. Tabs vs spaces in wsmux.c.
> 4. Tabs vs spaces in apm.c

committed, along with loongson apm.c which had the same spacing

> 2. Extra defines (to the best of my knowledge) in wsdisplayvar.h.
> 3. Unnecessary variable, in my opinion in wsdisplay.c.

I think these should be left as is, see sys/conf/files:
define	wsdisplaydev		{[mux = 1]}

> And finally, if you would be so kind,
> 5. Added device id in usbdevs (I know this doesn't make bluetooth

usbdevs change committed as well