From: Omar Polo <op@omarpolo.com>
Subject: Re: mg: move up directory in dired
To: Florian Obser <florian@openbsd.org>
Cc: Dante Catalfamo <dante@lambda.cx>, tech@openbsd.org
Date: Tue, 04 Jun 2024 08:53:53 +0200

On 2024/06/03 22:03:04 +0200, Florian Obser <florian@openbsd.org> wrote:
> On 2024-06-03 19:05 +02, Omar Polo <op@omarpolo.com> wrote:
> > On 2024/06/02 02:12:57 -0400, Dante Catalfamo <dante@lambda.cx> wrote:
> >> I had forgotten to add the command to the function map
> >
> > Looks great to me!  I've missed something like this to jump to the
> > parent directory quickly than searching for the '..' entry.
> >
> > I have a few nits, mostly on the style, but if noone complains I'll
> > commit in a few days.
> 
> OK florian

Thanks, committed (together with my proposed follow-up too since it was
trivial)

> > diff /usr/src
> > commit - 47c8d1014851805fa59b884ed3dceb148358575f
> > path + /usr/src
> > blob - 2fcb1c49f374b02c58136c3267d7171acfd2655e (staged)
> > file + usr.bin/mg/dired.c
> > --- usr.bin/mg/dired.c
> > +++ usr.bin/mg/dired.c
> > @@ -1125,7 +1125,7 @@ dired_jump(int f, int n)
> >  	for (i = 0; i <= curbp->b_nmodes; i++) {
> >  		modename = curbp->b_modes[i]->p_name;
> >  		if (strncmp(modename, "dired", 5) == 0)
> > -			return (dobeep_msg("In dired mode already"));
> > +			return (d_updirectory(f, n));
> >  	}
> >  
> >  	if (getbufcwd(dname, sizeof(dname)) != TRUE)
> >
> >
> > Thanks!
> >