From: Miod Vallat <miod@online.fr>
Subject: Re: Couple of style corrections
To: jon@elytron.openbsd.amsterdam
Cc: tech@openbsd.org
Date: Wed, 12 Jun 2024 14:48:41 +0000

> 1. I am aware that there are a few generated files like ukbd.h and
> such. At which point of the build process are they generated? I
> would guess at make config. Could you point me to the script that
> does the job please?

config(8) will produce a foo.h file containing a NFOO #define for every
driver which has the "needs-flag" or "needs-count" attribute in the
files.* declaring it.

> 2. After a closer inspection in sys/conf.h, I see there is a big
> mixup of tabs and spaces after #define, in the large #define cdev_*
> block. No one cares about this? I thought I would point it out,
> maybe you would want to make it more consistent. I fully agree that
> is such a minor thing compared to other stuff, just thought that,
> since I was lurking there and noticed, I might let people know.
> There are actually quite a few more than the ones I pointed out.

This is imo not worth cleaning unless there are other changes being done
in the file at the same time.