From: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH] acme-client: netproc.c: Eliminate dead code.
To: tech@openbsd.org
Cc: Tomas Volf <~@wolfsden.cz>
Date: Fri,  5 Jul 2024 17:02:52 +0200

Due to the test of the while loop, the cases for ORDER_VALID and ORDER_INVALID
can never be taken.

* usr.sbin/acme-client/netproc.c (netproc): Remove dead code.
---
 usr.sbin/acme-client/netproc.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/usr.sbin/acme-client/netproc.c b/usr.sbin/acme-client/netproc.c
index 25f296cdc55..f5abe040d7e 100644
--- a/usr.sbin/acme-client/netproc.c
+++ b/usr.sbin/acme-client/netproc.c
@@ -789,12 +789,6 @@ netproc(int kfd, int afd, int Cfd, int cfd, int dfd, int rfd,
 
 	while(order.status != ORDER_VALID && order.status != ORDER_INVALID) {
 		switch (order.status) {
-		case ORDER_INVALID:
-			warnx("order invalid");
-			goto out;
-		case ORDER_VALID:
-			rc = 1;
-			continue;
 		case ORDER_PENDING:
 			if (order.authsz < 1) {
 				warnx("order is in state pending but no "
-- 
2.45.1