From: Mike Larkin <mlarkin@nested.page>
Subject: Re: remove vn_isdisk()
To: tech@openbsd.org
Date: Sat, 6 Jul 2024 02:02:11 -0700

On Thu, Jul 04, 2024 at 09:10:20AM +1000, Jonathan Gray wrote:
> unused, added for softdep
>

ok mlarkin

> diff --git sys/kern/vfs_subr.c sys/kern/vfs_subr.c
> index 41c73c797e6..9dcdae0c6f5 100644
> --- sys/kern/vfs_subr.c
> +++ sys/kern/vfs_subr.c
> @@ -2225,18 +2225,6 @@ reassignbuf(struct buf *bp)
>  	bufinsvn(bp, listheadp);
>  }
>
> -/*
> - * Check if vnode represents a disk device
> - */
> -int
> -vn_isdisk(struct vnode *vp, int *errp)
> -{
> -	if (vp->v_type != VBLK && vp->v_type != VCHR)
> -		return (0);
> -
> -	return (1);
> -}
> -
>  #ifdef DDB
>  #include <machine/db_machdep.h>
>  #include <ddb/db_interface.h>
> diff --git sys/sys/vnode.h sys/sys/vnode.h
> index 23eebf37146..d06901f8d85 100644
> --- sys/sys/vnode.h
> +++ sys/sys/vnode.h
> @@ -642,7 +642,6 @@ void	vn_initialize_syncerd(void);
>  void	vn_syncer_add_to_worklist(struct vnode *, int);
>
>  /* misc */
> -int	vn_isdisk(struct vnode *, int *);
>  int 	getvnode(struct proc *, int, struct file **);
>
>  /* uvm */
>