From: Jonathan Gray Subject: Re: Samsung PM9C1 NVMe deviceid To: Bryan Vyhmeister Cc: Brandon Mercer , tech@openbsd.org Date: Sat, 10 Aug 2024 21:15:03 +1000 On Thu, Aug 08, 2024 at 11:13:13PM -0700, Bryan Vyhmeister wrote: > On Thu, Aug 08, 2024 at 12:34:20PM -0400, Brandon Mercer wrote: > > This diff correctly identifies my new samsung nvme: > > > > nvme0 at pci5 dev 0 function 0 "Samsung PM9C1 NVMe" rev 0x00: msix, NVMe 2.0 > > nvme0: Samsung SSD 990 PRO 4TB, firmware 0B2QJXG7, serial > > > > bmercer@ > > Here is a diff incorporating both bmercer's Samsung 990 Pro (PM9C1) and > my Samsung 990 EVO (PM9C1a). Before and after: > > nvme0 at pci5 dev 0 function 0 vendor "Samsung", unknown product 0xa80d rev 0x00: msix, NVMe 2.0 > nvme0: Samsung SSD 990 EVO 2TB, firmware 0B2QKXJ7, serial S7M4N1234567890 > > nvme0 at pci5 dev 0 function 0 "Samsung PM9C1a NVMe" rev 0x00: msix, NVMe 2.0 > nvme0: Samsung SSD 990 EVO 2TB, firmware 0B2QKXJ7, serial S7M4N1234567890 > > Bryan > > > Index: sys/dev/pci/pcidevs > =================================================================== > RCS file: /cvs/src/sys/dev/pci/pcidevs,v > diff -u -p -u -r1.2082 pcidevs > --- sys/dev/pci/pcidevs 9 Aug 2024 01:50:16 -0000 1.2082 > +++ sys/dev/pci/pcidevs 9 Aug 2024 05:34:03 -0000 > @@ -8955,6 +8955,8 @@ product SAMSUNG2 SM981_NVME 0xa808 SM981 > product SAMSUNG2 PM991_NVME 0xa809 PM991 NVMe > product SAMSUNG2 PM9A1_NVME 0xa80a PM9A1 NVMe > product SAMSUNG2 PM9B1_NVME 0xa80b PM9B1 NVMe > +product SAMSUNG2 PM9C1_NVME 0xa80c PM9C1 NVMe > +product SAMSUNG2 PM9C1a_NVME 0xa80d PM9C1a NVMe Should be PM9C1A_NVME not PM9C1a_NVME as we want the macro to be all uppercase. Index: pcidevs =================================================================== RCS file: /cvs/src/sys/dev/pci/pcidevs,v diff -u -p -r1.2082 pcidevs --- pcidevs 9 Aug 2024 01:50:16 -0000 1.2082 +++ pcidevs 10 Aug 2024 09:50:19 -0000 @@ -8955,6 +8955,8 @@ product SAMSUNG2 SM981_NVME 0xa808 SM981 product SAMSUNG2 PM991_NVME 0xa809 PM991 NVMe product SAMSUNG2 PM9A1_NVME 0xa80a PM9A1 NVMe product SAMSUNG2 PM9B1_NVME 0xa80b PM9B1 NVMe +product SAMSUNG2 PM9C1_NVME 0xa80c PM9C1 NVMe +product SAMSUNG2 PM9C1A_NVME 0xa80d PM9C1a NVMe product SAMSUNG2 NVME_171X 0xa820 NVMe product SAMSUNG2 NVME_172X 0xa821 NVMe product SAMSUNG2 NVME_172X_A_B 0xa822 NVMe