From: "Theo de Raadt" <deraadt@openbsd.org>
Subject: Re: procmap: remove "syscall" bit from header line
To: Christian Weisgerber <naddy@mips.inka.de>
Cc: tech@openbsd.org
Date: Tue, 27 Aug 2024 20:05:37 -0600

Ah yes, all I forgot the syscall thingy.

All good with me.

Christian Weisgerber <naddy@mips.inka.de> wrote:

> I ran procmap(8) and noticed some columns are slightly misaligned.
> 
> Stop printing the "syscall" bit in the header line, too.
> 
> OK?
>  
> diff 95d5c332c472650cdec05f73acaf97f6fd2475f4 dcfedb2ceca3cf894f785694a34f7b47660715fc
> commit - 95d5c332c472650cdec05f73acaf97f6fd2475f4
> commit + dcfedb2ceca3cf894f785694a34f7b47660715fc
> blob - c9a067751ea6f0b01cddda6fadbfdf579560084f
> blob + 43de9e382aba5086aa4d3049c77fde70de2c23dd
> --- usr.sbin/procmap/procmap.c
> +++ usr.sbin/procmap/procmap.c
> @@ -483,11 +483,11 @@ process_map(kvm_t *kd, pid_t pid, struct kinfo_proc *p
>  	/* headers */
>  #ifdef DISABLED_HEADERS
>  	if (print_map)
> -		printf("%-*s   %-*s rwxSe RWX CPY NCP I W A\n",
> +		printf("%-*s   %-*s rwxS RWX CPY NCP I W A\n",
>  		    (int)sizeof(long) * 2 + 2, "Start",
>  		    (int)sizeof(long) * 2 + 2, "End");
>  	if (print_maps)
> -		printf("%-*s   %-*s   rwxSep %-*s Dev   Inode      File\n",
> +		printf("%-*s   %-*s   rwxSp %-*s Dev   Inode      File\n",
>  		    (int)sizeof(long) * 2 + 0, "Start",
>  		    (int)sizeof(long) * 2 + 0, "End",
>  		    (int)sizeof(long) * 2 + 0, "Offset");
> @@ -497,7 +497,7 @@ process_map(kvm_t *kd, pid_t pid, struct kinfo_proc *p
>  		    (int)sizeof(int) * 2 - 1,  "Size ");
>  #endif
>  	if (print_all)
> -		printf("%-*s %-*s %*s %-*s rwxSeIpc  RWX  I/W/A Dev  %*s - File\n",
> +		printf("%-*s %-*s %*s %-*s rwxSIpc  RWX  I/W/A Dev  %*s - File\n",
>  		    (int)sizeof(long) * 2, "Start",
>  		    (int)sizeof(long) * 2, "End",
>  		    (int)sizeof(int)  * 2, "Size ",
> 
> -- 
> Christian "naddy" Weisgerber                          naddy@mips.inka.de
>