From: Hans-Jörg Höxer <Hans-Joerg_Hoexer@genua.de>
Subject: Re: [EXT] Re: AMD SEV 3/5:  Mention AMD PSP in ccp.4
To: <tech@openbsd.org>
Date: Thu, 29 Aug 2024 10:33:46 +0200

Hi,

On Thu, Aug 29, 2024 at 12:07:57PM +1000, Jonathan Gray wrote:
> > ...
> > +++ b/share/man/man4/ccp.4
> > @@ -33,6 +33,12 @@ The
> >  .Nm
> >  driver supports feeding output of the random number generator into
> >  the kernel entropy pool.
> > +.Pp
> > +On AMD EPYC processors
> 
> this line could be "On amd64" as the ioctls aren't only reachable on EPYC
> 
> even SEV doesn't appear to be EPYC only?

yes, you're right!  Updated diff below.

--------------------------------------------------------------------------
commit 5919499a4b3027e341ea71a49d9b342cd66c7d5c
Author: Hans-Joerg Hoexer <hshoexer@genua.de>
Date:   Wed Aug 28 12:49:21 2024 +0200

    ccp(4): mention PSP in ccp.4

diff --git a/share/man/man4/ccp.4 b/share/man/man4/ccp.4
index 942312f8bcd..4f300b1e811 100644
--- a/share/man/man4/ccp.4
+++ b/share/man/man4/ccp.4
@@ -33,6 +33,12 @@ The
 .Nm
 driver supports feeding output of the random number generator into
 the kernel entropy pool.
+.Pp
+On amd64
+.Nm
+provides
+.Xr ioctl 2
+access to the platform security processor (PSP).
 .Sh SEE ALSO
 .Xr intro 4 ,
 .Xr random 4 ,
@@ -48,3 +54,5 @@ The
 .Nm
 driver was written by
 .An David Gwynne Aq Mt dlg@openbsd.org .
+PSP support was implemented by
+.An Hans-Joerg Hoexer Aq Mt hshoexer@genua.de .