From: Rafael Sadowski <rafael@sizeofvoid.org>
Subject: Re: chatty libva
To: tech@openbsd.org
Date: Fri, 30 Aug 2024 16:59:01 +0200

On Fri Aug 30, 2024 at 08:58:45AM GMT, joshua stein wrote:
> This library seems unusually chatty for a base library...
> 
>     nano:~/Downloads$ vlc rewinding.webm
>     VLC media player 3.0.20 Vetinari (revision 3.0.20-0-g6f0d0ab126b)
>     QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-jcs'
>     libva info: VA-API version 1.22.0
>     libva info: Trying to open /usr/X11R6/lib/modules/dri/iHD_drv_video.so
>     libva info: Trying to open /usr/local/lib/dri/iHD_drv_video.so
>     libva info: Found init function __vaDriverInit_1_22
>     libva info: va_openDriver() returns 0
> 
> Do we want to silence it by default?
> 
> diff --git lib/libva/va/va.c lib/libva/va/va.c
> index 6d6ed1810..6a3ddee5e 100644
> --- lib/libva/va/va.c
> +++ lib/libva/va/va.c
> @@ -138,7 +138,7 @@ int vaDisplayIsValid(VADisplay dpy)
>   * whether default logging appears or not (always overridden by explicitly
>   * user-configured logging).
>   */
> -static int default_log_level = 2;
> +static int default_log_level = 1;
>  
>  static void default_log_error(void *user_context, const char *buffer)
>  {
> 

I prefer the default it makes user debug/error reports easier as well it
is the upstream default.