From: Theo Buehler <tb@theobuehler.org>
Subject: Re: Fix incorrect default editor path in GDB
To: Otto Moerbeek <otto@drijf.net>
Cc: Nir Lichtman <nir@lichtman.org>, tech@openbsd.org
Date: Thu, 19 Sep 2024 07:32:18 +0200

On Thu, Sep 19, 2024 at 07:25:08AM +0200, Otto Moerbeek wrote:
> On Wed, Sep 18, 2024 at 07:57:27PM +0000, Nir Lichtman wrote:
> 
> > diff --git gnu/usr.bin/binutils/gdb/cli/cli-cmds.c gnu/usr.bin/binutils/gdb/cli/cli-cmds.c
> > index fbe93c902..40ff739f7 100644
> > --- gnu/usr.bin/binutils/gdb/cli/cli-cmds.c
> > +++ gnu/usr.bin/binutils/gdb/cli/cli-cmds.c
> > @@ -625,7 +625,7 @@ edit_command (char *arg, int from_tty)
> >      }
> >  
> >    if ((editor = (char *) getenv ("EDITOR")) == NULL)
> > -      editor = "/bin/ex";
> > +      editor = "/usr/bin/ex";
> >    
> >    /* Approximate base-10 log of line to 1 unit for digit count */
> >    for(log10=32, m=0x80000000; !(sal.line & m) && log10>0; log10--, m=m>>1);
> > diff --git gnu/usr.bin/binutils/gdb/doc/gdb.texinfo gnu/usr.bin/binutils/gdb/doc/gdb.texinfo
> > index 6af8d3789..3de22cbc6 100644
> > --- gnu/usr.bin/binutils/gdb/doc/gdb.texinfo
> > +++ gnu/usr.bin/binutils/gdb/doc/gdb.texinfo
> > @@ -32,7 +32,7 @@
> >  @set EDITION Ninth
> >  
> >  @c !!set GDB edit command default editor
> > -@set EDITOR /bin/ex
> > +@set EDITOR /usr/bin/ex
> >  
> >  @c THIS MANUAL REQUIRES TEXINFO 4.0 OR LATER.
> >  
> > 
> 
> What makes you think this is correct?
> 
> $ which ed
> /bin/ed

ex, not ed

> 
> 	-Otto
>