From: Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject: kill unreachable code in sys_execve()
To: tech@openbsd.org
Date: Mon, 30 Sep 2024 11:51:15 +0200

After is no more process after calling exit1().
I see no point in this doubious code with a 0 return and a NOTREACHED
comment.

-- 
:wq Claudio

diff --git kern/kern_exec.c kern/kern_exec.c
index 76f4e70e2a6..e26183a3aa5 100644
--- kern/kern_exec.c
+++ kern/kern_exec.c
@@ -796,11 +796,6 @@ exec_abort:
 free_pack_abort:
 	free(pack.ep_hdr, M_EXEC, pack.ep_hdrlen);
 	exit1(p, 0, SIGABRT, EXIT_NORMAL);
-
-	/* NOTREACHED */
-	atomic_clearbits_int(&pr->ps_flags, PS_INEXEC);
-
-	return (0);
 }