From: Omar Polo <op@omarpolo.com>
Subject: Re: smtpd: allow braces for `listen' options
To: "Kirill A. Korinsky" <kirill@korins.ky>
Cc: tech@openbsd.org
Date: Sun, 20 Oct 2024 16:51:17 +0200

On 2024/10/20 01:53:27 +0200, Kirill A. Korinsky <kirill@korins.ky> wrote:
> On Fri, 18 Oct 2024 00:50:45 +0200,
> Omar Polo <op@omarpolo.com> wrote:
> > 
> > it seemed easier to say than to actually do it.  I'm attaching a trivial
> > diff for it, but there are some issues.  Your example has to be written
> > as
> > 
> > filter dnsbl proc-exec {
> > 	filter-dnsbl '-m' domain1 domain2
> > 		domain3 domain4
> > }
> > 
> > because otherwise a bare -m will lead to a syntax error.  Same story for
> > the usage of keywords inside the braces.
> >
> 
> well, adding support -m without escaping seems not that hacky, I not sure
> that I have broke as side effect, but as far as I see tohing.

i was thinking something way more complex, but your approach could work
as well too.  I'll need a moment to make sure we're not breaking other
cases, but I like it.

> Anyway, keywords is different story, yeah.

this is a pain in other contexts as well, so maybe we could just live
with it.  The manpage would need a note that "reserved keywords must be
quoted."

> And your patch works as excepted.

thank you for testing!