From: Jan Klemkow <jan@openbsd.org>
Subject: Re: ix: preparing vf support
To: YASUOKA Masahiko <yasuoka@openbsd.org>
Cc: tech@openbsd.org, naito.yuichiro@gmail.com, jmatthew@openbsd.org
Date: Sun, 3 Nov 2024 19:26:02 +0100

On Sun, Oct 27, 2024 at 02:45:55PM GMT, YASUOKA Masahiko wrote:
> On Thu, 24 Oct 2024 15:06:54 +0900 (JST)
> YASUOKA Masahiko <yasuoka@openbsd.org> wrote:
> > On Mon, 02 Sep 2024 13:27:04 +0900 (JST)
> > YASUOKA Masahiko <yasuoka@openbsd.org> wrote:
> >> I'm commiting ixv(4) from NAITO Yuichiro.  Almost of the changes can
> >> be done separately from ix(4), but the diff bellow is the part which
> >> actually affect ix(4).
> > 
> > This is the second step.  This diff will not affect existing ix(4)
> > because it only changes "mailbox" behavior.  "mailbox" is used only
> > for primary function or virtual function and our ix(4) doesn't support
> > either yet.
> 
> This is the final step.

Works for me.  I also tested it with TSO capabilities:
	ifp->if_capabilities |= IFCAP_TSOv4 | IFCAP_TSOv6;
But, this can be added afterwards.

> ixv(4) is still disabled on the config.

I guess we could enable ixv(4) it also by default.  It won't harm any
other part of the kernel as far as I can see.

Do you want to keep the style of sys/dev/pci/ixgbe_vf.c as is on
purpose, or can we adapt it to style(9) like the other files?

Below is a diff that fixes from lint reports of mandoc(1) for ixv.4.

bye,
jan

diff --git a/share/man/man4/ixv.4 b/share/man/man4/ixv.4
index 48e05e952..618b18245 100644
--- a/share/man/man4/ixv.4
+++ b/share/man/man4/ixv.4
@@ -36,15 +36,6 @@ driver supports the SR-IOV Virtual Functions of Intel 82598EB,
 .Xr pci 4 ,
 .Xr hostname.if 5 ,
 .Xr ifconfig 8
-.Sh BUGS
-The VF relies on
-.Dq vlan-filter
-to receive VLAN-tagged packets.
-Because the current driver doesn't have a way to configure it,
-any VLAN-tagged packets will not be passed.
-Alternatively,
-on the host running the primary function,
-there might be a way to configure a VLAN ID.
 .Sh HISTORY
 The
 .Nm
@@ -54,4 +45,16 @@ driver first appeared in
 The
 .Nm
 driver was written by
-Intel Corporation and ported to OpenBSD by NAITO Yuichiro.
+Intel Corporation and ported to
+.Ox
+by
+.An NAITO Yuichiro .
+.Sh BUGS
+The VF relies on
+.Dq vlan-filter
+to receive VLAN-tagged packets.
+Because the current driver doesn't have a way to configure it,
+any VLAN-tagged packets will not be passed.
+Alternatively,
+on the host running the primary function,
+there might be a way to configure a VLAN ID.