From: Hans-Jörg Höxer <hshoexer@genua.de>
Subject: Re: [EXT] psp(4) error cleanup
To: <tech@openbsd.org>
Date: Mon, 11 Nov 2024 13:14:31 +0100

On Mon, Nov 11, 2024 at 12:57:18PM +0100, Hans-Jörg Höxer wrote:
> > @@ -765,7 +757,8 @@ pspopen(dev_t dev, int flag, int mode, s
> >  	if (sc == NULL)
> >  		return (ENXIO);
> > 
> > -	psp_load_ucode(sc);
> > +	/* Ignore error, proceed without new firmware. */
> > +	(void) psp_load_ucode(sc);
> > 
> >  	if (!(sc->sc_flags & PSPF_INITIALIZED))
> >  		return (psp_reinit(sc));
...
> > @@ -933,7 +928,7 @@ psp_load_ucode(struct psp_softc *sc)
> >  		printf("%s: no firmware found, CPU family 0x%x model 0x%x\n",
> >  		    sc->sc_dev.dv_xname, family, model);
> >  		sc->sc_flags |= PSPF_NOUCODE;
> > -		return;
> > +		return (EOPNOTSUPP);
> 
> Is this too strict?  If we don't find a firmware, psp(4) will use the
> firmware from ROM.

I see, caller proceeds so we can stick with EOPNOTSUPP.