From: Paul Fertser Subject: Re: rkpmic(4) support system power down To: tech@openbsd.org Date: Thu, 21 Nov 2024 15:59:20 +0300 On Thu, Nov 21, 2024 at 03:03:32PM +0300, Paul Fertser wrote: > @@ -511,6 +538,11 @@ rkpmic_attach(struct device *parent, struct device *self, void *aux) > device_register_wakeup(&sc->sc_dev); > #endif > } > + > + if (OF_getpropbool(sc->sc_node, "rockchip,system-power-controller")) { This should first check for generic "system-power-controller" property as the rockchip-specific one was deprecated and removed from DTs. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/power/power-controller.txt