From: Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: rkpmic(4) support system power down
To: Paul Fertser <fercerpav@gmail.com>
Cc: tech@openbsd.org
Date: Fri, 22 Nov 2024 00:17:58 +0100

> Date: Thu, 21 Nov 2024 15:59:20 +0300
> From: Paul Fertser <fercerpav@gmail.com>
> 
> On Thu, Nov 21, 2024 at 03:03:32PM +0300, Paul Fertser wrote:
> > @@ -511,6 +538,11 @@ rkpmic_attach(struct device *parent, struct device *self, void *aux)
> >  			device_register_wakeup(&sc->sc_dev);
> >  #endif
> >  	}
> > +
> > +	if (OF_getpropbool(sc->sc_node, "rockchip,system-power-controller")) {
> 
> This should first check for generic "system-power-controller" property
> as the rockchip-specific one was deprecated and removed from DTs.

The order doesn't really matter, but yes, you should add a check like that.

> [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/power/power-controller.txt