From: Claudio Jeker Subject: Re: debug symbols in regress tests To: Theo Buehler Cc: tech@openbsd.org Date: Sun, 24 Nov 2024 14:09:24 +0100 On Sun, Nov 24, 2024 at 01:58:55PM +0100, Theo Buehler wrote: > On Sun, Nov 24, 2024 at 01:47:10PM +0100, Claudio Jeker wrote: > > On Sun, Nov 24, 2024 at 10:09:49AM +0100, Theo Buehler wrote: > > > On Mon, Nov 04, 2024 at 11:32:47AM +0100, Theo Buehler wrote: > > > > When a regress test fails or crashes, it's useful to have debugging > > > > symbols available and it is a bit annoying to have to recompile. Is > > > > there a reason not to have them available by default - other than maybe > > > > disk space in obj/ on the machines that run full regress? > > > > > > I'd still like to have this. Any concern/objections? > > > > I also would like this. I just wonder if this should use DEBUG instead of > > CFLAGS but I'm always lost at all the ways to fiddle with the compiler > > tool chain. > > Thanks, makes sense. It's what bsd.lib.mk does as well and it works for > me. If this is preferred, I'm happy with that. If this is what's used in bsd.lib.mk then it may be better to use that. I dislike "DEBUG ?= -g" because it may drop -g if make is called with DEBUG set to something else. I hit this case in kernel builds from time to time which results in no ctf symbols and a lot of cursing. One could maybe use DEBUG += -g but as I said, I'm lost with all the knobs that our Makefiles provide. > Index: bsd.regress.mk > =================================================================== > RCS file: /cvs/src/share/mk/bsd.regress.mk,v > diff -u -p -r1.27 bsd.regress.mk > --- bsd.regress.mk 24 Sep 2023 08:28:20 -0000 1.27 > +++ bsd.regress.mk 24 Nov 2024 12:55:44 -0000 > @@ -4,6 +4,8 @@ > # No man pages for regression tests. > NOMAN= > > +DEBUG ?= -g > + > # No installation. > install: > > -- :wq Claudio