From: Kirill A. Korinsky <kirill@korins.ky>
Subject: Re: Support Jabra PanaCast 20 webcam
To: Klemens Nanni <kn@openbsd.org>
Cc: Marcus Glocker <marcus@nazgul.ch>, me@xha.li, tech@openbsd.org
Date: Sat, 30 Nov 2024 18:58:05 +0100

On Sat, 30 Nov 2024 18:46:42 +0100,
Klemens Nanni <kn@openbsd.org> wrote:
> 
> Quirk looks good.
> 
> 30.11.2024 17:59, Marcus Glocker пишет:
> >> +#define UVIDEO_FLAG_RENEGOTIATE_AFTER_SET_ALT	0x16
> > Please change this to the hex representation of 16 which is 0x10 :-)
> 
> Perhaps just UVIDEO_FLAG_RENEGOTIATE ?
> 
> ... ah, just you committed it.

I don't think so. Just renegotiate might be misleading, because the code has
another negotiation controlled by sc_negotiated_flag in the same function. I
think this naming makes things clear.

-- 
wbr, Kirill