From: Theo Buehler Subject: Re: bgpd: rfc8654 extended message support To: tech@openbsd.org Date: Mon, 9 Dec 2024 12:15:17 +0100 > > > @@ -3536,6 +3539,7 @@ lookup(char *s) > > > { "export", EXPORT}, > > > { "export-target", EXPORTTRGT}, > > > { "ext-community", EXTCOMMUNITY}, > > > + { "extended", EXTENDED }, > > > > other members have no space before }, > > Actually that table is a mess. There are both versions. I want to unify > this. I thought of adding a space before } for all of them. What do you > prefer? Right... Removing the spaces in that one table is less churn, but adding one seems more consistent with the rest of the file, where everything seems to have a space (except addpathextra and addpathmax where there's a tab). While there, I'd also add a trailing comma to the tables that don't have one: lookup[], toswords[], icmp_type[], icmp_code[]