From: Theo Buehler <tb@theobuehler.org>
Subject: Re: bgpd vs bison: rename some enums
To: tech@openbsd.org
Date: Mon, 16 Dec 2024 16:47:32 +0100

On Mon, Dec 16, 2024 at 04:40:25PM +0100, Claudio Jeker wrote:
> Bison uses an enum for the yacc tokens and so we end up with the
> redefinition of NOTIFICATION.
> 
> parse.c:390:5: warning: declaration shadows a variable in the global scope
> [-Wshadow]
>   390 |     NOTIFICATION = 318,            /* NOTIFICATION  */
>       |     ^
> ./session.h:75:2: note: previous declaration is here
>    75 |         NOTIFICATION,
>       |         ^
> 
> Now it is easier to prefix the msg_type enums in session.h so the below
> diff does that. With that make YACC=bison works.

Yes, that seems the right approach.

ok tb