From: Alexander Bluhm <bluhm@openbsd.org>
Subject: Re: make tcp_mss() MP safe
To: Vitaliy Makkoveev <mvs@openbsd.org>
Cc: tech@openbsd.org
Date: Tue, 24 Dec 2024 13:43:08 +0100

On Mon, Dec 23, 2024 at 01:38:00AM +0300, Vitaliy Makkoveev wrote:
> On Sat, Dec 21, 2024 at 12:50:37AM +0100, Alexander Bluhm wrote:
> > @@ -679,14 +680,14 @@ extern	struct pool tcpcb_pool;
> >  extern	struct inpcbtable tcbtable, tcb6table;	/* queue of active tcpcb's */
> >  extern	int tcp_do_rfc1323;	/* enabled/disabled? */
> >  extern	int tcptv_keep_init;	/* [N] time to keep alive initial SYN packet */
> > -extern	int tcp_mssdflt;	/* default maximum segment size */
> > +extern	int tcp_mssdflt;	/* [N] default maximum segment size */
> >  extern	int tcp_rst_ppslim;	/* maximum outgoing RST packet per second */
> 
> Please, put locks description to the tcp_usrreq.c where variables are
> defined. Also `tcp_mssdflt' should be  [a], not [N]. The rest is ok mvs@.

I think it not so clear where the MP comment belongs.  At least our
code is inconsistent.  I commited tcp_mss() without theses comments.
Let's address them in a different diff with more cleanup.

bluhm