From: Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject: Re: bgpd: flowspec & unknown AFI/SAFI are not VPNv6
To: Denis Fondras <denis@openbsd.org>
Cc: tech@openbsd.org
Date: Fri, 3 Jan 2025 20:21:58 +0100

On Fri, Jan 03, 2025 at 04:58:35PM +0100, Denis Fondras wrote:
> copy/paste I guess :)
> 
> Index: rde.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/bgpd/rde.c,v
> diff -u -p -r1.646 rde.c
> --- rde.c	12 Dec 2024 20:19:03 -0000	1.646
> +++ rde.c	3 Jan 2025 15:56:05 -0000
> @@ -1598,7 +1598,7 @@ rde_update_dispatch(struct rde_peer *pee
>  				if (ibuf_skip(&unreachbuf,
>  				    ibuf_size(&unreachbuf)) == -1) {
>  					log_peer_warnx(&peer->conf,
> -					    "bad VPNv6 withdraw prefix");
> +					    "unsupported withdraw prefix");
>  					rde_update_err(peer, ERR_UPDATE,
>  					    ERR_UPD_OPTATTR, &unreachbuf);
>  					goto done;
> @@ -1778,7 +1778,7 @@ rde_update_dispatch(struct rde_peer *pee
>  				if (ibuf_skip(&reachbuf,
>  				    ibuf_size(&reachbuf)) == -1) {
>  					log_peer_warnx(&peer->conf,
> -					    "bad VPNv6 withdraw prefix");
> +					    "unsupported withdraw prefix");
>  					rde_update_err(peer, ERR_UPDATE,
>  					    ERR_UPD_OPTATTR, &reachbuf);
>  					goto done;
> 

I doubt that code is reachable but I think the error message should be
"bad withdraw prefix" since this is an error path for the case that
ibuf_skip fails.

-- 
:wq Claudio