From: Marcus Glocker <marcus@nazgul.ch>
Subject: Re: sys/ihidev: add missed looking for a device quirks
To: "Kirill A. Korinsky" <kirill@korins.ky>
Cc: tech@openbsd.org
Date: Tue, 7 Jan 2025 23:59:10 +0100

On Tue, Jan 07, 2025 at 11:45:12PM GMT, Kirill A. Korinsky wrote:

> tech@,
> 
> working with a few patches which changes the same code is a nightmare,
> and I had missed one chunk with the last diff which looking for a device
> quirks.
> 
> Ok?

Ops.  I also did oversee this line in your last diff.

ok mglocker@
 
> Index: sys/dev/i2c/ihidev.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/i2c/ihidev.c,v
> diff -u -p -u -p -r1.36 ihidev.c
> --- sys/dev/i2c/ihidev.c	7 Jan 2025 15:25:18 -0000	1.36
> +++ sys/dev/i2c/ihidev.c	7 Jan 2025 22:40:11 -0000
> @@ -632,6 +632,8 @@ ihidev_reset(struct ihidev_softc *sc)
>  int
>  ihidev_hid_desc_parse(struct ihidev_softc *sc)
>  {
> +	sc->sc_quirks = ihidev_quirks(sc);
> +
>  	/* must be v01.00 */
>  	if (letoh16(sc->hid_desc.bcdVersion) != 0x0100) {
>  		printf("%s: bad HID descriptor bcdVersion (0x%x)\n",
> 
> -- 
> wbr, Kirill
>