From: Theo Buehler <tb@theobuehler.org>
Subject: Re: sys/uvideo: bypass unknown pixelformat to consumer
To: Marcus Glocker <marcus@nazgul.ch>
Cc: "Kirill A. Korinsky" <kirill@korins.ky>, tech@openbsd.org
Date: Sat, 11 Jan 2025 14:14:55 +0100

> > +	/* map GUID to pixel format if a matching entry is found */
> > +	for (j = 0, nent = nitems(uvideo_map_fmts); j < nent; j++) {
> > +		if (!memcmp(sc->sc_fmtgrp[i].format->u.uc.guidFormat,
> > +			    uvideo_map_fmts[j].guidFormat, 16)) {

Secondary indent should be four spaces:

		if (!memcmp(sc->sc_fmtgrp[i].format->u.uc.guidFormat,
		    uvideo_map_fmts[j].guidFormat, 16)) {

> > +			sc->sc_fmtgrp[i].pixelformat =
> > +				uvideo_map_fmts[j].pixelformat;

here, too:

			sc->sc_fmtgrp[i].pixelformat =
			    uvideo_map_fmts[j].pixelformat;