From: Marcus Glocker <marcus@nazgul.ch>
Subject: Re: sys/uvideo: bypass unknown pixelformat to consumer
To: Theo Buehler <tb@theobuehler.org>,  "Kirill A. Korinsky" <kirill@korins.ky>
Cc: tech@openbsd.org
Date: Sat, 11 Jan 2025 14:42:01 +0100

On Sat, Jan 11, 2025 at 02:14:55PM GMT, Theo Buehler wrote:

> > > +	/* map GUID to pixel format if a matching entry is found */
> > > +	for (j = 0, nent = nitems(uvideo_map_fmts); j < nent; j++) {
> > > +		if (!memcmp(sc->sc_fmtgrp[i].format->u.uc.guidFormat,
> > > +			    uvideo_map_fmts[j].guidFormat, 16)) {
> 
> Secondary indent should be four spaces:
> 
> 		if (!memcmp(sc->sc_fmtgrp[i].format->u.uc.guidFormat,
> 		    uvideo_map_fmts[j].guidFormat, 16)) {
> 
> > > +			sc->sc_fmtgrp[i].pixelformat =
> > > +				uvideo_map_fmts[j].pixelformat;
> 
> here, too:
> 
> 			sc->sc_fmtgrp[i].pixelformat =
> 			    uvideo_map_fmts[j].pixelformat;
> 

Agree.  If you could in-corporate this as well Kirill please.