From: Sebastien Marie <semarie@kapouay.eu.org>
Subject: Re: iscsid: fix text_to_bool and text_to_digest handling of errstrp
To: Claudio Jeker <cjeker@diehard.n-r-g.com>, tech@openbsd.org
Date: Thu, 23 Jan 2025 12:02:33 +0100

Claudio Jeker <cjeker@diehard.n-r-g.com> writes:

> I introduced a bug when I refactored text_to_bool and added
> text_to_digest.
>
> These function need to set errstr to NULL on successful return, since the
> caller does check for that.
>
> I think the netbsd-iscsi-target does not hit these cases since it does not
> send any of the affected keys that would trigger the bug.

I found `text_to_bool()' lot more readable this way.

ok semarie@
-- 
Sebastien Marie