From: Kirill A. Korinsky <kirill@korins.ky>
Subject: Re: wg(4) logging enhancement - revised patch
To: Lloyd <ng2d68@proton.me>
Cc: Vitaliy Makkoveev <mvs@openbsd.org>, Stuart Henderson <stu@spacehopper.org>, "tech@openbsd.org" <tech@openbsd.org>
Date: Thu, 23 Jan 2025 20:34:25 +0100

I haven't tried it, but here a few more nitpicking which I've noticed when
read this diff.

On Thu, 23 Jan 2025 20:11:36 +0100, Lloyd <ng2d68@proton.me> wrote:
> @@ -1144,23 +1154,29 @@ wg_timers_run_retry_handshake(void *_t)
>  {
>  	struct wg_timers *t = _t;
>  	struct wg_peer	 *peer = CONTAINER_OF(t, struct wg_peer, p_timers);
> +	char		 ipaddr[INET6_ADDRSTRLEN];
>  

I think you need an extra space here, before i character.

> @@ -1188,10 +1204,13 @@ wg_timers_run_new_handshake(void *_t)
>  {
>  	struct wg_timers *t = _t;
>  	struct wg_peer	 *peer = CONTAINER_OF(t, struct wg_peer, p_timers);
> +	char		 ipaddr[INET6_ADDRSTRLEN];
>

and probably here as well.

> @@ -1202,8 +1221,12 @@ wg_timers_run_zero_key_material(void *_t)
>  {
>  	struct wg_timers *t = _t;
>  	struct wg_peer	 *peer = CONTAINER_OF(t, struct wg_peer, p_timers);
> +	char		 ipaddr[INET6_ADDRSTRLEN];
>  

and probably here.

-- 
wbr, Kirill