From: Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: ignore SR_IRQ in ipmi_acpi
To: YASUOKA Masahiko <yasuoka@openbsd.org>
Cc: patrick@openbsd.org, jsg@jsg.id.au, kettenis@openbsd.org, tech@openbsd.org
Date: Mon, 27 Jan 2025 11:12:59 +0100

> Date: Mon, 27 Jan 2025 16:46:45 +0900 (JST)
> From: YASUOKA Masahiko <yasuoka@openbsd.org>
> 
> Hi,
> 
> I'm testing "HPE ProLiant DL20 Gen11".  Attacing ipmi0 on that machine
> fails with the message below:
>   
>   ipmi0 at acpi0
>   ipmi0: unexpected resource #1 type 4ipmi0: incomplete resources (ift 1)
> 
> The machine has a "type 4" = SR_IRQ variable in _CRS and the current
> driver doesn't handle that type.  The driver already ignores for
> LR_EXTIRQ.
> 
> ok?

ok kettenis@

> Index: sys/dev/acpi/ipmi_acpi.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/acpi/ipmi_acpi.c,v
> diff -u -p -r1.6 ipmi_acpi.c
> --- sys/dev/acpi/ipmi_acpi.c	9 Oct 2024 00:38:25 -0000	1.6
> +++ sys/dev/acpi/ipmi_acpi.c	27 Jan 2025 07:37:47 -0000
> @@ -137,6 +137,9 @@ ipmi_acpi_parse_crs(int crsidx, union ac
>  	char iotype;
>  
>  	switch (type) {
> +	case SR_IRQ:
> +		/* Ignore for now. */
> +		return 0;
>  	case SR_IOPORT:
>  		addr = crs->sr_ioport._max;
>  		iotype = 'i';
>