From: Johannes Thyssen Tishman <johannes@thyssentishman.com>
Subject: Re: Chromebook Keyboard
To: Brandon Mercer <bmercer@eutonian.com>
Cc: tech@openbsd.org
Date: Tue, 11 Feb 2025 08:43:10 +0000

2025-02-11T08:31:34Z Johannes Thyssen Tishman 
<johannes@thyssentishman.com>:

> 2025-02-11T02:11:38Z Brandon Mercer <bmercer@eutonian.com>:
>
>> With the recent addition of pckbc_acpi, it seems only a small change 
>> is
>> needed for my chromebook keyboard to work. This is running on an acer
>> CP514-3HH-R6VK
>>
>> diff /home/bmercer/src
>> path + /home/bmercer/src
>> commit - c7df606a226b2afe5e5ddf0eb9f8fa7a1638d0fe
>> blob - ab6368f0ece350b2d78d377b699002b7983d205c
>> file + sys/dev/acpi/pckbc_acpi.c
>> --- sys/dev/acpi/pckbc_acpi.c
>> +++ sys/dev/acpi/pckbc_acpi.c
>> @@ -130,6 +130,7 @@ pckbc_acpi_attach(struct device *parent, struct 
>> device
>> }
>>
>> const char *pckbc_acpi_cids_kbd[] = {
>> +   "GOOG000A", /* Chromebook built-in keyboard */
>>     "PNP0303",  /* IBM Enhanced Keyboard (101/102-key, PS/2 Mouse) */
>>     NULL
>> };
>
> You shouldn't need this with the latest diff in the thread:
>
> https://marc.info/?l=openbsd-tech&m=173917591326140&w=2

Oh wait, I might be wrong here. I thought that list wasn't needed anymore 
based on the following:

Mood:
> This should remove the need for a list of "known to need acpi
> attachment" devices, and in fact, I have removed it now.

I thought it was referring to this list, but I realize
>> it's still
there. Sorry for the noise.